You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/06 15:25:41 UTC
[GitHub] [tvm] wrongtest opened a new pull request #10176: resolve issue #10107 by setting eps larger
wrongtest opened a new pull request #10176:
URL: https://github.com/apache/tvm/pull/10176
https://github.com/apache/tvm/issues/10107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10176: resolve issue #10107 by setting eps larger
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #10176:
URL: https://github.com/apache/tvm/pull/10176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10176: resolve issue #10107 by setting eps larger
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10176:
URL: https://github.com/apache/tvm/pull/10176#issuecomment-1033099337
Might need to rebase on main to solve some CI errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10176: resolve issue #10107 by setting eps larger
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10176:
URL: https://github.com/apache/tvm/pull/10176#issuecomment-1031712355
Flaky test it looks like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #10176: resolve issue #10107 by setting eps larger
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on a change in pull request #10176:
URL: https://github.com/apache/tvm/pull/10176#discussion_r800878803
##########
File path: tests/python/unittest/test_tir_schedule_sampling.py
##########
@@ -190,7 +190,7 @@ def test_sample_compute_location():
n_candidates = 8
expected_rate = 1.0 / n_candidates
for _, cnt in decision_dict.items():
- assert (expected_rate - 0.03) * n <= cnt <= (expected_rate + 0.03) * n
+ assert (expected_rate - 0.04) * n <= cnt <= (expected_rate + 0.04) * n
Review comment:
Can you jsut use numpy.testing.assert_allclose ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org