You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/02 01:03:08 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #9443:
Re-enable the AnnotationLayerModelView read API
etr2460 opened a new pull request #9443: Re-enable the AnnotationLayerModelView read API
URL: https://github.com/apache/incubator-superset/pull/9443
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
According to https://github.com/apache/incubator-superset/blob/291306392443a5a0d0e2ee0cc4a95d37c56d4589/superset-frontend/src/explore/components/controls/AnnotationLayer.jsx#L265, this API is still being used on the client side. This fixes a regression from https://github.com/apache/incubator-superset/pull/8960 where the endpoint was accidentally removed.
In the future we should probably migrate the client to use a new endpoint, but for now this fixes the regression.
### TEST PLAN
CI, ensure the annotationlayer selector loads instead of returning a 404
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @mistercrunch @john-bodley @dpgaspar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9443: Re-enable
the AnnotationLayerModelView read API
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9443: Re-enable the AnnotationLayerModelView read API
URL: https://github.com/apache/incubator-superset/pull/9443#issuecomment-607569988
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=h1) Report
> Merging [#9443](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/621b4816b39a091dadd0b33af83246ac689b4fa6&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9443 +/- ##
=======================================
Coverage 59.02% 59.02%
=======================================
Files 379 379
Lines 12189 12189
Branches 3014 3014
=======================================
Hits 7194 7194
Misses 4814 4814
Partials 181 181
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=footer). Last update [621b481...675f8d7](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 opened a new pull request #9443:
Re-enable the AnnotationLayerModelView read API
Posted by GitBox <gi...@apache.org>.
etr2460 opened a new pull request #9443: Re-enable the AnnotationLayerModelView read API
URL: https://github.com/apache/incubator-superset/pull/9443
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
According to https://github.com/apache/incubator-superset/blob/291306392443a5a0d0e2ee0cc4a95d37c56d4589/superset-frontend/src/explore/components/controls/AnnotationLayer.jsx#L265, this API is still being used on the client side. This fixes a regression from https://github.com/apache/incubator-superset/pull/8960 where the endpoint was accidentally removed.
In the future we should probably migrate the client to use a new endpoint, but for now this fixes the regression.
### TEST PLAN
CI, ensure the annotationlayer selector loads instead of returning a 404
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @mistercrunch @john-bodley @dpgaspar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #9443: Re-enable
the AnnotationLayerModelView read API
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9443: Re-enable the AnnotationLayerModelView read API
URL: https://github.com/apache/incubator-superset/pull/9443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9443:
Re-enable the AnnotationLayerModelView read API
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9443: Re-enable the AnnotationLayerModelView read API
URL: https://github.com/apache/incubator-superset/pull/9443#issuecomment-607569988
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=h1) Report
> Merging [#9443](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/621b4816b39a091dadd0b33af83246ac689b4fa6&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9443 +/- ##
=======================================
Coverage 59.02% 59.02%
=======================================
Files 379 379
Lines 12189 12189
Branches 3014 3014
=======================================
Hits 7194 7194
Misses 4814 4814
Partials 181 181
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=footer). Last update [621b481...675f8d7](https://codecov.io/gh/apache/incubator-superset/pull/9443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 closed pull request #9443: Re-enable
the AnnotationLayerModelView read API
Posted by GitBox <gi...@apache.org>.
etr2460 closed pull request #9443: Re-enable the AnnotationLayerModelView read API
URL: https://github.com/apache/incubator-superset/pull/9443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org