You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/02/11 00:52:28 UTC

[kudu-CR](branch-1.18.x) [codegen] fix build on macOS

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23961


Change subject: [codegen] fix build on macOS
......................................................................

[codegen] fix build on macOS

This addresses linker error on macOS:

    void google::MakeCheckOpValueString<std::nullptr_t>(...), referenced from:
        ... google::MakeCheckOpString<std::nullptr_t, void*>(...) in jit_frame_manager.cc.o
  ld: symbol(s) not found for architecture x86_64

This is a follow-up to 0efbebd487e7d0c7f21ab0d5a91e0fa70046af83.

Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Reviewed-on: http://gerrit.cloudera.org:8080/23943
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
(cherry picked from commit 514a3ff1a3b0ed912498a079ba73c7afcdd1a753)
---
M src/kudu/codegen/jit_frame_manager.cc
1 file changed, 3 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/23961/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23961
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) [codegen] fix build on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23961 )

Change subject: [codegen] fix build on macOS
......................................................................


Patch Set 1: Verified+1

TSAN: unrelated failures of known flaky tests


-- 
To view, visit http://gerrit.cloudera.org:8080/23961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23961
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Feb 2026 05:28:16 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [codegen] fix build on macOS

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23961 )

Change subject: [codegen] fix build on macOS
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2269/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23961
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Feb 2026 02:16:08 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [codegen] fix build on macOS

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23961 )

Change subject: [codegen] fix build on macOS
......................................................................

[codegen] fix build on macOS

This addresses linker error on macOS:

    void google::MakeCheckOpValueString<std::nullptr_t>(...), referenced from:
        ... google::MakeCheckOpString<std::nullptr_t, void*>(...) in jit_frame_manager.cc.o
  ld: symbol(s) not found for architecture x86_64

This is a follow-up to 0efbebd487e7d0c7f21ab0d5a91e0fa70046af83.

Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Reviewed-on: http://gerrit.cloudera.org:8080/23943
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
(cherry picked from commit 514a3ff1a3b0ed912498a079ba73c7afcdd1a753)
Reviewed-on: http://gerrit.cloudera.org:8080/23961
---
M src/kudu/codegen/jit_frame_manager.cc
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Marton Greber: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/23961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23961
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR](branch-1.18.x) [codegen] fix build on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [codegen] fix build on macOS
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23961
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR](branch-1.18.x) [codegen] fix build on macOS

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23961 )

Change subject: [codegen] fix build on macOS
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2269/


-- 
To view, visit http://gerrit.cloudera.org:8080/23961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23961
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Feb 2026 00:52:37 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [codegen] fix build on macOS

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23961 )

Change subject: [codegen] fix build on macOS
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I00743d0a452ab5e33c3441cac4e06ff1bf58b7a6
Gerrit-Change-Number: 23961
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Feb 2026 10:49:52 +0000
Gerrit-HasComments: No