You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/03 21:02:28 UTC

[GitHub] [arrow] rtpsw commented on a diff in pull request #14485: ARROW-17980: [C++] As-of-Join Substrait extension

rtpsw commented on code in PR #14485:
URL: https://github.com/apache/arrow/pull/14485#discussion_r1013394435


##########
cpp/src/arrow/engine/substrait/options.h:
##########
@@ -23,7 +23,11 @@
 #include <string>
 #include <vector>
 
+#include <google/protobuf/any.pb.h>

Review Comment:
   I'm not familiar with libarrow_python build, but it sounds like you're saying adding this would be bad. Should the APIs involving `Any` be made internal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org