You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/23 10:31:16 UTC
[GitHub] [shardingsphere] Lucas-307 opened a new pull request #7006: Add unit test for shardingsphere-scaling
Lucas-307 opened a new pull request #7006:
URL: https://github.com/apache/shardingsphere/pull/7006
Fixes #6813.
Changes proposed in this pull request:
- Add unit test
- ScalingEntryLoaderTest
- MySQLBinlogDumperTest
- JdbcUriTest
- refactor MySQLBinlogDumper
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #7006: Add unit test for shardingsphere-scaling
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7006:
URL: https://github.com/apache/shardingsphere/pull/7006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7006: Add unit test for shardingsphere-scaling
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7006:
URL: https://github.com/apache/shardingsphere/pull/7006#issuecomment-678760056
## Pull Request Test Coverage Report for [Build 14035](https://coveralls.io/builds/32937648)
* **8** of **10** **(80.0%)** changed or added relevant lines in **4** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.09%**) to **35.194%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-scaling/shardingsphere-scaling-mysql/src/main/java/org/apache/shardingsphere/scaling/mysql/MySQLPositionManager.java](https://coveralls.io/builds/32937648/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fmysql%2FMySQLPositionManager.java#L64) | 0 | 1 | 0.0%
| [shardingsphere-scaling/shardingsphere-scaling-postgresql/src/main/java/org/apache/shardingsphere/scaling/postgresql/PostgreSQLPositionManager.java](https://coveralls.io/builds/32937648/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fpostgresql%2FPostgreSQLPositionManager.java#L69) | 0 | 1 | 0.0%
<!-- | **Total:** | **8** | **10** | **80.0%** | -->
| Totals | [](https://coveralls.io/builds/32937648) |
| :-- | --: |
| Change from base [Build 14033](https://coveralls.io/builds/32936450): | 0.09% |
| Covered Lines: | 35355 |
| Relevant Lines: | 100457 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org