You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/16 10:08:38 UTC
[GitHub] [incubator-superset] thammaneni opened a new issue #10063: Can we achieve "adding prefix to all superset routes" ?
thammaneni opened a new issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063
A clear and concise description of what the bug is.
I am trying to add default prefix to all superset route points but there are many places route points are hard coded is there any way we can fix this or already fixed?
The below link might give you more explanation, i am not sure whether superset has fix for this or not. Can you guys please throw some ideas here if it is achievable?
Ref : https://github.com/apache/incubator-superset/issues/3690
### Expected results
what you expected to happen.
### Actual results
what actually happens.
#### Screenshots
If applicable, add screenshots to help explain your problem.
#### How to reproduce the bug
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
### Environment
(please complete the following information):
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-691271233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bryantjcb commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
bryantjcb commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-742397775
Is there any update about this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-644669288
Issue-Label Bot is automatically applying the label `#question` to this issue, with a confidence of 0.82. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] lexisstv commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
lexisstv commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-654671107
Unfortunately, I'm new to python, and not sure about the quality of my hotfixes. I’ll try to find the time to arrange the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-691271233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-691271233
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-655302082
One good place to start would be to use `flask.url_for` for all hard coded url paths on the backend. Then there's a need to do some flask trickery to add a prefix to all existing routes (not sure whether that's easy and how hacky it would be, but likely fairly hacky). Then the frontend needs to get that prefix and use it to all routes as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] lexisstv commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
lexisstv commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-647110377
Yeah. I'm spend 2 days to modify all direct links for move superset to subpath (except tests)... Glad if this will be fixed...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] lexisstv commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
lexisstv commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-691663514
Please, don't close this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] summerswallow-whi commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
summerswallow-whi commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-657677818
I'm very interested in this issue. Seems from what I've read, that for some organization this could be a make or break reason to use Superset as might be the case for my organization as well. Seeing what transpired in the PR#3690. I would suggest multiple PR. I think the part of the reason it failed is because they were trying to fix the whole problem at once and since the project progressed with hundreds of PR during the time resolving conflicts became a great burden.
Seems that even if all the PR does is converts to `flask.url_for` that is a better coding practice than hard coded paths could be the first PR. This would be a code quality enhancement rather than feature enhancement. Once in you start taking on the next problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai closed issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
nytai closed issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-734495341
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-649098848
I've seen this issue crop up a number of times, and I think the problem is that we do not have contributors from organizations where this is an issue. We would, however, be open to a PR that introduces the feature. @lexisstv if you've made the updates in code already and would be willing to share that as a PR it would help us understand the scope required for the change. I'd be happy to support a new contributor who wants to make this enhancement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org