You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bridges-commits@portals.apache.org by ta...@apache.org on 2007/02/23 19:51:51 UTC

svn commit: r511047 - in /portals/bridges/trunk: applications/jsf-demo/src/webapp/WEB-INF/portlet.xml jsf/src/java/org/apache/portals/bridges/jsf/FacesPortlet.java

Author: taylor
Date: Fri Feb 23 10:51:50 2007
New Revision: 511047

URL: http://svn.apache.org/viewvc?view=rev&rev=511047
Log:
experiencing some intermittent behavior with my last patch to the uniqueness of an jsf id
making it optional

Modified:
    portals/bridges/trunk/applications/jsf-demo/src/webapp/WEB-INF/portlet.xml
    portals/bridges/trunk/jsf/src/java/org/apache/portals/bridges/jsf/FacesPortlet.java

Modified: portals/bridges/trunk/applications/jsf-demo/src/webapp/WEB-INF/portlet.xml
URL: http://svn.apache.org/viewvc/portals/bridges/trunk/applications/jsf-demo/src/webapp/WEB-INF/portlet.xml?view=diff&rev=511047&r1=511046&r2=511047
==============================================================================
--- portals/bridges/trunk/applications/jsf-demo/src/webapp/WEB-INF/portlet.xml (original)
+++ portals/bridges/trunk/applications/jsf-demo/src/webapp/WEB-INF/portlet.xml Fri Feb 23 10:51:50 2007
@@ -69,7 +69,11 @@
         <init-param>
             <name>portlet-icon</name>
             <value>office-calendar.png</value>
-        </init-param>           
+        </init-param>     
+        <init-param>
+        	<name>OverrideUniqueIds</name>
+        	<value>true</value>
+        </init-param>      
         <expiration-cache>-1</expiration-cache>		        
         <supports>
 			<mime-type>text/html</mime-type>

Modified: portals/bridges/trunk/jsf/src/java/org/apache/portals/bridges/jsf/FacesPortlet.java
URL: http://svn.apache.org/viewvc/portals/bridges/trunk/jsf/src/java/org/apache/portals/bridges/jsf/FacesPortlet.java?view=diff&rev=511047&r1=511046&r2=511047
==============================================================================
--- portals/bridges/trunk/jsf/src/java/org/apache/portals/bridges/jsf/FacesPortlet.java (original)
+++ portals/bridges/trunk/jsf/src/java/org/apache/portals/bridges/jsf/FacesPortlet.java Fri Feb 23 10:51:50 2007
@@ -108,6 +108,9 @@
     /** Help request. */
     public static final String HELP_REQUEST = "HELP";
 
+    /** Override default behavior for Unique IDS */
+    public static final String PARAM_UNIQUE_IDS = "OverrideUniqueIds";
+    
     /** Default URL for the action page. */
     private String defaultActionPage = null;
 
@@ -123,6 +126,8 @@
     /** Default URL for the view page. */
     private String defaultViewPage = null;
 
+    private String uniqueIds = null;
+    
     /**
      * <p>
      * Context initialization parameter name for the lifecycle identifier of the
@@ -206,6 +211,7 @@
         this.defaultViewPage = portletConfig.getInitParameter(PARAM_VIEW_PAGE);
         this.defaultEditPage = portletConfig.getInitParameter(PARAM_EDIT_PAGE);
         this.defaultHelpPage = portletConfig.getInitParameter(PARAM_HELP_PAGE);
+        this.uniqueIds = portletConfig.getInitParameter(PARAM_UNIQUE_IDS);
         
         if (null == this.defaultViewPage)
         {
@@ -531,15 +537,18 @@
         {
             key = key + ":" + view;
         }
-        PortletResponse response = (PortletResponse)context.getExternalContext().getResponse();
-        if (!(response instanceof RenderResponse))
-        {
-            log.error("Cant encode action response");
-        }
-        else
+        if (uniqueIds != null)
         {
-            RenderResponse rr = (RenderResponse)response;
-            key = key + rr.getNamespace();
+            PortletResponse response = (PortletResponse)context.getExternalContext().getResponse();
+            if (!(response instanceof RenderResponse))
+            {
+                log.error("Cant encode action response");
+            }
+            else
+            {
+                RenderResponse rr = (RenderResponse)response;
+                key = key + rr.getNamespace();
+            }
         }
         return key;
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-commits-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-commits-help@portals.apache.org