You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org> on 2011/12/15 01:11:31 UTC
[jira] [Commented] (ZOOKEEPER-1202) Prevent certain state
transitions in Java client on close(); improve exception handling and
enhance client testability
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169845#comment-13169845 ]
Hadoop QA commented on ZOOKEEPER-1202:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12496216/ZOOKEEPER-1202.patch
against trunk revision 1214571.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/830//console
This message is automatically generated.
> Prevent certain state transitions in Java client on close(); improve exception handling and enhance client testability
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1202
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1202
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Matthias Spycher
> Assignee: Matthias Spycher
> Attachments: ZOOKEEPER-1202.patch
>
>
> ZooKeeper.close() doesn't force the client into a CLOSED state. While the closing flag ensures that the client will close, its state may end up in CLOSED, CONNECTING or CONNECTED.
> I developed a patch and in the process cleaned up a few other things primarily to enable testing of state transitions.
> - ClientCnxnState is new and enforces certain state transitions
> - ZooKeeper.isExpired() is new
> - ClientCnxn no longer refers to ZooKeeper, WatchManager is externalized, and ClientWatchManager includes 3 new methods
> - The SendThread terminates the EventThread on a call to close() via the event-of-death
> - Polymorphism is used to handle internal exceptions (SendIOExceptions)
> - The patch incorporates ZOOKEEPER-126.patch and prevents close() from blocking
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira