[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #496: nimble/gap: Fix for checking sc only mode

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #496: nimble/gap: Fix for checking sc only mode
URL: https://github.com/apache/mynewt-nimble/pull/496#discussion_r294822158
 
 

 ##########
 File path: nimble/host/src/ble_sm.c
 ##########
 @@ -1723,6 +1723,20 @@ ble_sm_pair_exec(struct ble_sm_proc *proc, struct ble_sm_result *res,
     }
 }
 
+static bool
+ble_sm_verify_auth_requirements(uint8_t authreq)
+{
+    /* For now we check only SC only mode. I.e.: when remote request
+     * for legacy pairing, make sure legacy pairing is supported.
 
 Review comment:
   I'd reword this since remote cannot *request* legacy pairing, it just indicates whether it support LE SC - if it does not support LE SC, we need to support legacy pairing and this is what we check here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services