You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/18 21:08:41 UTC

[GitHub] [beam] bullet03 opened a new pull request, #24268: [Website] change svg to png

bullet03 opened a new pull request, #24268:
URL: https://github.com/apache/beam/pull/24268

   - change svg to png to some logos
   ------------------------
   before:
   ![before_svg](https://user-images.githubusercontent.com/61748758/202802644-b163903f-dd61-45aa-b030-76318e5ea008.JPG)
   after:
   ![after_png](https://user-images.githubusercontent.com/61748758/202802623-0e1affdf-8809-4f63-ba38-502f02a7411e.JPG)
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1334413115

   thanks. I'd like to understand -why are we changing SVG to PNG?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1330943543

   @pabloem, could you kindly help with review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1326449555

   @pabloem, could you kindly help with review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1334431410

   > thanks. I'd like to understand -why are we changing SVG to PNG?
   
   To keep consistency, since other images in the relative folders were pngs. Unfortunately I wasn't aware of that and used svgs instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1334432864

   lgtm thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #24268:
URL: https://github.com/apache/beam/pull/24268


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1333610758

   R:@pabloem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1334438968

   > lgtm thanks
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1333610103

   R:@pabloem, could you kindly help with review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AlyaBoiko commented on pull request #24268: [Website] change svg to png

Posted by GitBox <gi...@apache.org>.
AlyaBoiko commented on PR #24268:
URL: https://github.com/apache/beam/pull/24268#issuecomment-1322430137

   Verified, works as expected. Reviewed and tested by QA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org