You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "divijvaidya (via GitHub)" <gi...@apache.org> on 2023/06/29 15:40:40 UTC

[GitHub] [kafka] divijvaidya opened a new pull request, #13935: MINOR: Fix debug logs to display TimeIndexOffset

divijvaidya opened a new pull request, #13935:
URL: https://github.com/apache/kafka/pull/13935

   This change correctly prints the offset associated with a time index entry instead of printing the reference of the Java object. 
   
   **Debug logs before this change:**
   Notice the value of `last entry is now` string in the logs
   ```
   [2023-06-29 16:54:14,753] DEBUG Truncated index /var/folders/b7/gtty4gtx1nxcnd9qwgqr536m0000gr/T/kafka15182151620663328910.tmp to 0 entries; position is now 0 and last entry is now org.apache.kafka.storage.internals.log.TimestampOffset@2d (org.apache.kafka.storage.internals.log.TimeIndex:280)
   ```
   
   Notice the value of `lastOffset =` string in the logs
   ```
   [2023-06-29 17:00:29,768] DEBUG Loaded index file /var/folders/b7/gtty4gtx1nxcnd9qwgqr536m0000gr/T/kafka12970272451741393509.tmp with maxEntries = 30, maxIndexSize = 360, entries = 0, lastOffset = org.apache.kafka.storage.internals.log.TimestampOffset@2d, file position = 0 (org.apache.kafka.storage.internals.log.TimeIndex:68)
   ```
   
   **Debug logs after this change:**
   ```
   [2023-06-29 17:06:11,621] DEBUG Truncated index /var/folders/b7/gtty4gtx1nxcnd9qwgqr536m0000gr/T/kafka10329570089261941057.tmp to 0 entries; position is now 0 and last entry is now 45 (org.apache.kafka.storage.internals.log.TimeIndex:280)
   ```
   
   ```
   [2023-06-29 17:32:05,351] DEBUG Loaded index file /var/folders/b7/gtty4gtx1nxcnd9qwgqr536m0000gr/T/kafka17205967388538316017.tmp with maxEntries = 30, maxIndexSize = 360, entries = 0, lastOffset = 45, file position = 0 (org.apache.kafka.storage.internals.log.TimeIndex:68)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya commented on pull request #13935: MINOR: Fix debug logs to display TimeIndexOffset

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13935:
URL: https://github.com/apache/kafka/pull/13935#issuecomment-1615046002

   Unrelated test failures
   ```
   [Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicationWithEmptyPartition()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13935/2/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest/Build___JDK_8_and_Scala_2_12___testReplicationWithEmptyPartition__/)
   [Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testSyncTopicConfigs()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13935/2/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest/Build___JDK_8_and_Scala_2_12___testSyncTopicConfigs__/)
   [Build / JDK 8 and Scala 2.12 / kafka.admin.TopicCommandIntegrationTest.testDescribeAtMinIsrPartitions(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13935/2/testReport/junit/kafka.admin/TopicCommandIntegrationTest/Build___JDK_8_and_Scala_2_12___testDescribeAtMinIsrPartitions_String__quorum_kraft/)
   [Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerBounceTest.testSubscribeWhenTopicUnavailable()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13935/2/testReport/junit/kafka.api/ConsumerBounceTest/Build___JDK_8_and_Scala_2_12___testSubscribeWhenTopicUnavailable__/)
   [Build / JDK 8 and Scala 2.12 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13935/2/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_8_and_Scala_2_12___testBalancePartitionLeaders__/)
   [Build / JDK 11 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.[1] Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13935/2/testReport/junit/kafka.zk/ZkMigrationIntegrationTest/Build___JDK_11_and_Scala_2_13____1__Type_ZK__Name_testDualWrite__MetadataVersion_3_4_IV0__Security_PLAINTEXT/)
   [Build / JDK 11 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13935/2/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_11_and_Scala_2_13___testBalancePartitionLeaders__/)
   [Build / JDK 11 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13935/2/testReport/junit/org.apache.kafka.trogdor.coordinator/CoordinatorTest/Build___JDK_11_and_Scala_2_13___testTaskRequestWithOldStartMsGetsUpdated__/)
   ```
   
   @showuon requesting review for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya merged pull request #13935: MINOR: Fix debug logs to display TimeIndexOffset

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya merged PR #13935:
URL: https://github.com/apache/kafka/pull/13935


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org