You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/04 07:42:44 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #19632: [FLINK-27485][Documentation][Build] Fix the documentation build pipeline
MartijnVisser opened a new pull request, #19632:
URL: https://github.com/apache/flink/pull/19632
## What is the purpose of the change
* Fix the currently broken documentation build pipeline
## Brief change log
* Use different Git command (which is supported by the installed Git version on the Docker image)
* Upgrading Hugo and making sure that this is added to the PATH by extracting it to `/usr/local/bin`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19632: [FLINK-27485][Documentation][Build] Fix the documentation build pipeline
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19632:
URL: https://github.com/apache/flink/pull/19632#issuecomment-1117108810
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19632: [FLINK-27485][Documentation][Build] Fix the documentation build pipeline
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19632:
URL: https://github.com/apache/flink/pull/19632#issuecomment-1117018700
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b1dd4a38512c692d2fd68364e562bedaafe9f12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0b1dd4a38512c692d2fd68364e562bedaafe9f12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b1dd4a38512c692d2fd68364e562bedaafe9f12 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19632: [FLINK-27485][Documentation][Build] Fix the documentation build pipeline
Posted by GitBox <gi...@apache.org>.
zentol merged PR #19632:
URL: https://github.com/apache/flink/pull/19632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #19632: [FLINK-27485][Documentation][Build] Fix the documentation build pipeline
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #19632:
URL: https://github.com/apache/flink/pull/19632#discussion_r864546667
##########
.github/workflows/docs.sh:
##########
@@ -23,13 +23,13 @@ java -version
javadoc -J-version
# setup hugo
-HUGO_REPO=https://github.com/gohugoio/hugo/releases/download/v0.80.0/hugo_extended_0.80.0_Linux-64bit.tar.gz
-HUGO_ARTIFACT=hugo_extended_0.80.0_Linux-64bit.tar.gz
+HUGO_REPO=https://github.com/gohugoio/hugo/releases/download/v0.98.0/hugo_extended_0.98.0_Linux-64bit.tar.gz
+HUGO_ARTIFACT=hugo_extended_0.98.0_Linux-64bit.tar.gz
if ! curl --fail -OL $HUGO_REPO ; then
echo "Failed to download Hugo binary"
exit 1
fi
-tar -zxvf $HUGO_ARTIFACT
+tar -zxvf $HUGO_ARTIFACT -C /usr/local/bin
Review Comment:
Yes of course :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19632: [FLINK-27485][Documentation][Build] Fix the documentation build pipeline
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19632:
URL: https://github.com/apache/flink/pull/19632#discussion_r864539574
##########
.github/workflows/docs.sh:
##########
@@ -23,13 +23,13 @@ java -version
javadoc -J-version
# setup hugo
-HUGO_REPO=https://github.com/gohugoio/hugo/releases/download/v0.80.0/hugo_extended_0.80.0_Linux-64bit.tar.gz
-HUGO_ARTIFACT=hugo_extended_0.80.0_Linux-64bit.tar.gz
+HUGO_REPO=https://github.com/gohugoio/hugo/releases/download/v0.98.0/hugo_extended_0.98.0_Linux-64bit.tar.gz
+HUGO_ARTIFACT=hugo_extended_0.98.0_Linux-64bit.tar.gz
if ! curl --fail -OL $HUGO_REPO ; then
echo "Failed to download Hugo binary"
exit 1
fi
-tar -zxvf $HUGO_ARTIFACT
+tar -zxvf $HUGO_ARTIFACT -C /usr/local/bin
Review Comment:
Don't the `./hugo` calls below need to updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org