You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "lowka (via GitHub)" <gi...@apache.org> on 2023/06/30 17:10:38 UTC

[GitHub] [ignite-3] lowka commented on a diff in pull request #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

lowka commented on code in PR #2275:
URL: https://github.com/apache/ignite-3/pull/2275#discussion_r1248100317


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/internal/InternalSchemaTest.java:
##########
@@ -93,12 +92,23 @@ public void testDropColumns() {
 
         checkDdl(true, ses, "ALTER TABLE my ADD COLUMN (c2 INT, c4 VARCHAR)");
 
+        ses.execute(
+                null,
+                "INSERT INTO my VALUES (2, '2', 2, '3')"
+        );
+
         res = ses.execute(
                 null,
-                "SELECT c1, c3 FROM my"
+                "SELECT c2, c4 FROM my WHERE c1=2"
         );
 
-        assertNotNull(res.next());
+        SqlRow result = res.next();
+
+        assertNotNull(result);
+        System.err.println(result.metadata().columns());

Review Comment:
   I think you forgot to remove this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org