You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by GitBox <gi...@apache.org> on 2026/05/06 06:56:49 UTC
[GH] (texera/main): Workflow run "npm_and_yarn in /frontend for follow-redirects - Update #1350792826" failed!
The GitHub Actions job "npm_and_yarn in /frontend for follow-redirects - Update #1350792826" on texera.git/main has failed.
Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]).
Head commit for run:
34b004d012cc6a87fc2611a666aa1376d159c462 / Yicong Huang <17...@users.noreply.github.com>
fix(amber): surface writer-thread failure as FatalError instead of silent hang (#4683)
### What changes were proposed in this PR?
When `OutputPortResultWriterThread.run()` throws (e.g. iceberg
commit-retry budget exhausted), the writer thread dies silently and the
worker still reports `portCompleted` to the controller. The user sees a
1-minute completion timeout with no signal pointing at iceberg.
Capture the failure on the writer thread, re-throw it from
`OutputManager.closeOutputStorageWriterIfNeeded`, and let the existing
DP-thread → worker-actor → controller-supervisor path surface it as a
`FatalError` to the client.
### Any related issues, documentation, discussions?
Closes #4682.
### How was this PR tested?
`OutputPortResultWriterThreadSpec` (6 tests) covers clean run, putOne
failure (close() still runs), close() failure, both-fail (close()
suppressed on putOne), and
`OutputManager.closeOutputStorageWriterIfNeeded` re-throw + no-op cases.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7, 1M context)
---------
Co-authored-by: Claude Opus 4.7 (1M context) <no...@anthropic.com>
Report URL: https://github.com/apache/texera/actions/runs/25420981461
With regards,
GitHub Actions via GitBox