[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/992#discussion_r38409485
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java ---
    @@ -42,11 +42,13 @@
     	private boolean retryForever;
     	private Socket socket;
     	private static final int CONNECTION_TIMEOUT_TIME = 0;
    -	private static final int CONNECTION_RETRY_SLEEP = 1000;
    +	static int CONNECTION_RETRY_SLEEP = 1000;
    +	protected long retries;
     
     	private volatile boolean isRunning;
     
     	public SocketTextStreamFunction(String hostname, int port, char delimiter, long maxRetry) {
    +		this.retries = 0;
    --- End diff --
    
    Initialization to `0` is not needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---