You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/28 06:08:47 UTC

[GitHub] [spark] LuciferYang opened a new pull request #35987: [SPARK-37673][TESTS] Replace Java assert with Junit API in Java UTs

LuciferYang opened a new pull request #35987:
URL: https://github.com/apache/spark/pull/35987


   ### What changes were proposed in this pull request?
   There are some Java UTs use java `assert` for assertion, and these assertions will strongly depend on JVM start with `-ea` mode, so this pr replace them with Junit API.
   
   
   ### Why are the changes needed?
   Use Junit API in Java UTs.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35987: [SPARK-38673][TESTS] Replace Java assert with Junit API in Java UTs

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35987:
URL: https://github.com/apache/spark/pull/35987#issuecomment-1081245674


   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #35987: [SPARK-38673][TESTS] Replace Java assert with Junit API in Java UTs

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35987:
URL: https://github.com/apache/spark/pull/35987#issuecomment-1080609954


   after [913ba45](https://github.com/apache/spark/pull/35987/commits/913ba4534d38f9cf6d386fd6d5440c14895cc047), I think that's all
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #35987: [SPARK-38673][TESTS] Replace Java assert with Junit API in Java UTs

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35987:
URL: https://github.com/apache/spark/pull/35987


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #35987: [SPARK-38673][TESTS] Replace Java assert with Junit API in Java UTs

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35987:
URL: https://github.com/apache/spark/pull/35987#issuecomment-1081340556


   thanks all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #35987: [SPARK-38673][TESTS] Replace Java assert with Junit API in Java UTs

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35987:
URL: https://github.com/apache/spark/pull/35987#issuecomment-1080597459


   > Looks good if that is all of them
   
   Let me check again
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org