You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/02/11 16:57:03 UTC

DO NOT REPLY [Bug 50763] New: [PATCH] Size basic-link areas according to descendant areas

https://issues.apache.org/bugzilla/show_bug.cgi?id=50763

           Summary: [PATCH] Size basic-link areas according to descendant
                    areas
           Product: Fop
           Version: all
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: page-master/layout
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: vhennebert@gmail.com


Created an attachment (id=26641)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26641)
Patch implementing the change

The descendants of an inline-area are not taken into account when computing the
height of the inline-area.

The main real-life scenario is the following: when an image is surrounded by a
basic-link element, only a small part of it becomes active ("clickable"), not
the whole image.

See full discussion there:
http://markmail.org/thread/d2a5p4dufipdgfp2

Bug report at W3C: http://www.w3.org/Bugs/Public/show_bug.cgi?id=11672

The attached patch breaks the XSL-FO 1.1 Recommendation and sizes basic-link
areas according to their descendant areas. More precisely, the
block-progression-dimension of the content-rectangles of basic-link areas is
computed so as to encompass all the allocation-rectangles of the descendant
areas.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50763] [PATCH] Size basic-link areas according to descendant areas

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50763

Vincent Hennebert <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kamal.bhatt@gmail.com

--- Comment #1 from Vincent Hennebert <vh...@gmail.com> 2011-02-11 11:00:05 EST ---
*** Bug 42501 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50763] [PATCH] Size basic-link areas according to descendant areas

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50763

--- Comment #4 from Vincent Hennebert <vh...@gmail.com> 2012-01-11 19:43:07 UTC ---
Hi Chris,

The patch was committed in rev. 1085058 following a vote on fop-dev@:
http://markmail.org/thread/oxxsx5ljvoxdqvhu

This bug has been left open as a reminder that adjustments might be required
once the XSL-FO Working Group has provided clarification.

Vincent

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: DO NOT REPLY [Bug 50763] New: [PATCH] Size basic-link areas according to descendant areas

Posted by Vincent Hennebert <vh...@gmail.com>.
Folks,

Can you please review the attached patch and let me know what you think.
If we decide to apply it to Trunk we are going to deliberately break the
XSL-FO 1.1 Recommendation. I believe it’s something we want to do
anyway, as I honestly think there’s a bug in the Recommendation on this
regard; At least as far as basic-link is concerned.

I’ll launch a vote in a few days for the integration of this feature to
Trunk.

Thanks,
Vincent


On 11/02/11 15:57, bugzilla@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=50763
> 
>            Summary: [PATCH] Size basic-link areas according to descendant
>                     areas
>            Product: Fop
>            Version: all
>           Platform: All
>         OS/Version: All
>             Status: NEW
>           Severity: normal
>           Priority: P2
>          Component: page-master/layout
>         AssignedTo: fop-dev@xmlgraphics.apache.org
>         ReportedBy: vhennebert@gmail.com
> 
> 
> Created an attachment (id=26641)
>  --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26641)
> Patch implementing the change
> 
> The descendants of an inline-area are not taken into account when computing the
> height of the inline-area.
> 
> The main real-life scenario is the following: when an image is surrounded by a
> basic-link element, only a small part of it becomes active ("clickable"), not
> the whole image.
> 
> See full discussion there:
> http://markmail.org/thread/d2a5p4dufipdgfp2
> 
> Bug report at W3C: http://www.w3.org/Bugs/Public/show_bug.cgi?id=11672
> 
> The attached patch breaks the XSL-FO 1.1 Recommendation and sizes basic-link
> areas according to their descendant areas. More precisely, the
> block-progression-dimension of the content-rectangles of basic-link areas is
> computed so as to encompass all the allocation-rectangles of the descendant
> areas.
>

DO NOT REPLY [Bug 50763] [PATCH] Size basic-link areas according to descendant areas

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50763

--- Comment #3 from Chris Bowditch <bo...@hotmail.com> 2012-01-10 16:39:54 UTC ---
Hi Vincent,

Are you going to commit this patch or are you waiting for a response from the
W3C Subgroup?

Thanks,

Chris

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50763] [PATCH] Size basic-link areas according to descendant areas

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50763

--- Comment #2 from Vincent Hennebert <vh...@gmail.com> 2011-03-09 11:45:33 EST ---
Bug has been raised at W3C:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11672

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50763] [PATCH] Size basic-link areas according to descendant areas

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50763

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Glenn Adams <gl...@skynav.com> 2012-04-05 05:24:11 UTC ---
patch already applied; if future input from XSL-FO group, then can reopen or
open new bug

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.