You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/22 18:48:51 UTC

[GitHub] [kafka] C0urante commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

C0urante commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-647707645


   Thanks for the insight @michael-carter-instaclustr. This type of direct user feedback and perspective is invaluable! I'm convinced that your interpretation is likely the more useful of the two (assuming that we don't exclusively count failures during `start` and also include failures while trying to instantiate plugins, etc., which it seems like you're on board with).
   
   I haven't reviewed the tests for this change yet but the design seems good and as soon as the code review comments are addressed I'm happy to do another round and, if everything still looks good, give my plus one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org