You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/07 10:35:15 UTC
[GitHub] [doris] zy-kkk opened a new pull request, #12438: [improvement](error info)improve the s3 path err msg
zy-kkk opened a new pull request, #12438:
URL: https://github.com/apache/doris/pull/12438
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #12438: [improvement](error info)improve the s3 path err msg
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #12438:
URL: https://github.com/apache/doris/pull/12438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #12438: [improvement](error info)improve the s3 path err msg
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #12438:
URL: https://github.com/apache/doris/pull/12438#discussion_r964699114
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java:
##########
@@ -244,7 +244,7 @@ public static String checkPath(String path, StorageBackend.StorageType type) thr
}
} else if (type == StorageBackend.StorageType.S3) {
if (schema == null || !schema.equalsIgnoreCase("s3")) {
- throw new AnalysisException("Invalid export path. please use valid 'S3://' path.");
+ throw new AnalysisException("Invalid export path. please use valid 's3://' path.");
Review Comment:
!schema.equalsIgnoreCase("s3")
why we need change 'S3' to 's3'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on a diff in pull request #12438: [improvement](error info)improve the s3 path err msg
Posted by GitBox <gi...@apache.org>.
zy-kkk commented on code in PR #12438:
URL: https://github.com/apache/doris/pull/12438#discussion_r964709125
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java:
##########
@@ -244,7 +244,7 @@ public static String checkPath(String path, StorageBackend.StorageType type) thr
}
} else if (type == StorageBackend.StorageType.S3) {
if (schema == null || !schema.equalsIgnoreCase("s3")) {
- throw new AnalysisException("Invalid export path. please use valid 'S3://' path.");
+ throw new AnalysisException("Invalid export path. please use valid 's3://' path.");
Review Comment:
When the s3 path entered by the user is wrong, we should return the correct prompt information, and returning 'S3' is wrong, so I changed to the correct 's3'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org