You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@taverna.apache.org by st...@apache.org on 2018/05/11 10:44:34 UTC
[08/14] incubator-taverna-language git commit: Can't expect to parse
annotations with no "content"
Can't expect to parse annotations with no "content"
.. as they were slightly wrong from BDBAg example
using "uri" property instead.
Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/commit/2cb004de
Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/tree/2cb004de
Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/diff/2cb004de
Branch: refs/heads/master
Commit: 2cb004deb1b7fe5770b9aadc20cf398929d07cf2
Parents: ea43200
Author: Stian Soiland-Reyes <st...@apache.org>
Authored: Thu May 10 18:21:46 2018 +0100
Committer: Stian Soiland-Reyes <st...@apache.org>
Committed: Thu May 10 18:22:40 2018 +0100
----------------------------------------------------------------------
.../taverna/robundle/manifest/TestRDFToManifest.java | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/blob/2cb004de/taverna-robundle/src/test/java/org/apache/taverna/robundle/manifest/TestRDFToManifest.java
----------------------------------------------------------------------
diff --git a/taverna-robundle/src/test/java/org/apache/taverna/robundle/manifest/TestRDFToManifest.java b/taverna-robundle/src/test/java/org/apache/taverna/robundle/manifest/TestRDFToManifest.java
index 13e099e..7ebc5ad 100644
--- a/taverna-robundle/src/test/java/org/apache/taverna/robundle/manifest/TestRDFToManifest.java
+++ b/taverna-robundle/src/test/java/org/apache/taverna/robundle/manifest/TestRDFToManifest.java
@@ -77,11 +77,14 @@ public class TestRDFToManifest {
author.getName());
assertEquals(URI.create("mbox:stain@apache.org"),
author.getUri());
- // FIXME: Why is ORCID not picked up?
-// assertEquals(URI.create("https://orcid.org/0000-0001-9842-9718"),
-// author.getOrcid());
+ assertEquals(URI.create("https://orcid.org/0000-0001-9842-9718"),
+ author.getOrcid());
- // FIXME: Why are annotations not picked up?
+
+ // FIXME: The BDBag got this wrong and used "uri" instead of "content", and so
+ // data/README accidentally became the ID of the annotation.
+ // That means that we can't find any annotations as we only pick up
+ // on those that have a "content"
// assertEquals(1, manifest.getAnnotations().size());
// PathAnnotation ann = manifest.getAnnotations().get(0);
// assertEquals(ro.getRoot().toUri(),