[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7307: Saving author to local storage in snitch dialog

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #7307: Saving author to local storage in snitch dialog
URL: https://github.com/apache/incubator-druid/pull/7307#discussion_r267579371
 
 

 ##########
 File path: web-console/src/dialogs/snitch-dialog.tsx
 ##########
 @@ -27,6 +27,9 @@ import {
 import * as React from 'react';
 
 import { FormGroup, IconNames } from '../components/filler';
+import { localStorageGet, localStorageSet } from "../utils";
+
+const druidEditingAuthor = "DRUID_EDITING_AUTHOR";
 
 Review comment:
   Would it make sense to consolidate keys that are being used for local storage... somewhere, like maybe export a const somewhere or something with all the keys and document what they do and what uses them, to make it easy to coordinate and re-use storage between views and make sure there are no conflicts? Or would this be too general? I noticed that there are dynamic storage key values I guess, from #7292 which uses the table name as the storage key so it's on the views to not step on each other or anything else.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org