You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/08/05 22:22:06 UTC

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6160: [ONNX]Mod operator, bug fix

masahi commented on a change in pull request #6160:
URL: https://github.com/apache/incubator-tvm/pull/6160#discussion_r466036755



##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -530,10 +530,11 @@ class Mod(OnnxOpConverter):
     @classmethod
     def _impl_v1(cls, inputs, attr, params):
         assert len(inputs) == 2, "Mod op take 2 inputs, {} given".format(len(inputs))
-        if attr['fmod'] == 1:
+        if attr['fmod'] == 0:

Review comment:
       Can we add a comment here to avoid confusion?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org