You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by hx...@apache.org on 2020/04/16 07:25:25 UTC

[incubator-iotdb] branch disable_mqtt_server updated: add log to see why

This is an automated email from the ASF dual-hosted git repository.

hxd pushed a commit to branch disable_mqtt_server
in repository https://gitbox.apache.org/repos/asf/incubator-iotdb.git


The following commit(s) were added to refs/heads/disable_mqtt_server by this push:
     new 49c4d57  add log to see why
49c4d57 is described below

commit 49c4d57502df0628f187aa121f0942cc2c4324ed
Author: xiangdong huang <sa...@gmail.com>
AuthorDate: Thu Apr 16 15:25:07 2020 +0800

    add log to see why
---
 .../thrift/server/CustomizedTThreadPoolServer.java       | 16 +++++++++-------
 server/src/test/resources/logback.xml                    |  1 +
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/server/src/main/java/org/apache/thrift/server/CustomizedTThreadPoolServer.java b/server/src/main/java/org/apache/thrift/server/CustomizedTThreadPoolServer.java
index 6cbaa9c..5d6da67 100644
--- a/server/src/main/java/org/apache/thrift/server/CustomizedTThreadPoolServer.java
+++ b/server/src/main/java/org/apache/thrift/server/CustomizedTThreadPoolServer.java
@@ -44,7 +44,7 @@ import org.slf4j.LoggerFactory;
 public class CustomizedTThreadPoolServer extends TServer {
   private static final Logger LOGGER = LoggerFactory.getLogger(TThreadPoolServer.class.getName());
 
-  private volatile boolean stopped_ = false;
+  private volatile boolean myStop = true;
 
   public static class Args extends AbstractServerArgs<Args> {
     public int minWorkerThreads = 5;
@@ -162,7 +162,8 @@ public class CustomizedTThreadPoolServer extends TServer {
     if (eventHandler_ != null) {
       eventHandler_.preServe();
     }
-    stopped_ = false;
+    LOGGER.info("set myStop to false");
+    myStop = false;
     super.stopped_ = false;
     setServing(true);
 
@@ -182,7 +183,7 @@ public class CustomizedTThreadPoolServer extends TServer {
 
   protected void execute() {
     int failureCount = 0;
-    while (!this.stopped_) {
+    while (!this.myStop) {
       try {
         TTransport client = serverTransport_.accept();
         WorkerProcess wp = new WorkerProcess(client);
@@ -227,9 +228,9 @@ public class CustomizedTThreadPoolServer extends TServer {
           }
         }
       } catch (TTransportException ttx) {
-        if (!stopped_) {
+        if (!myStop) {
           ++failureCount;
-          LOGGER.warn("Stopped: {}. Transport error occurred during acceptance of message.", stopped_, ttx);
+          LOGGER.warn("Stopped: {}. Transport error occurred during acceptance of message.", myStop, ttx);
         }
       }
     }
@@ -257,7 +258,8 @@ public class CustomizedTThreadPoolServer extends TServer {
   }
 
   public void stop() {
-    this.stopped_ = true;
+    LOGGER.info("set myStop to true");
+    this.myStop = true;
     super.stopped_ = true;
     serverTransport_.interrupt();
   }
@@ -310,7 +312,7 @@ public class CustomizedTThreadPoolServer extends TServer {
             eventHandler.processContext(connectionContext, inputTransport, outputTransport);
           }
 
-          if (stopped_) {
+          if (myStop) {
             break;
           }
           processor.process(inputProtocol, outputProtocol);
diff --git a/server/src/test/resources/logback.xml b/server/src/test/resources/logback.xml
index b9ef1b3..7ebde9d 100644
--- a/server/src/test/resources/logback.xml
+++ b/server/src/test/resources/logback.xml
@@ -50,6 +50,7 @@
     <logger name="org.apache.iotdb.db.service.MQTTService" level="INFO"/>
     <logger name="org.apache.iotdb.db.service.MQTTService" level="INFO"/>
     <logger name="org.apache.iotdb.db.sync.receiver.SyncServerManager" level="INFO"/>
+    <logger name="org.apache.thrift.server.CustomizedTThreadPoolServer" level="INFO" />
 
     <root level="WARN">
         <appender-ref ref="stdout"/>