You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by duncangrant <gi...@git.apache.org> on 2017/11/17 09:14:54 UTC

[GitHub] brooklyn-server pull request #900: Fix VSP stop/start when ssh monitoring di...

GitHub user duncangrant opened a pull request:

    https://github.com/apache/brooklyn-server/pull/900

    Fix VSP stop/start when ssh monitoring disabled

    When stop / starting a VanillaSoftwareProcess with ssh monitoring the
    process will never be marked as healthy after a stop start.
    
    On a restart the feeds are not disconnected so a service.notup.indicator
    is set.  When this is cleared on start the ServiceNotUpLogic will detect
    the change and set the isUp sensor true.  However when stopping the
    process feeds are disconnected so no service.notup indicators are set.
    This means the ServiceNotUp logic will not detect a change on start and
    won't set the service isUp sensor to true.
    
    Fixed by setting a service.notUp.indicator on stop.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duncangrant/brooklyn-server fix-vanillasp-stop-start

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/900.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #900
    
----
commit dc34d06ed15f82b00d89dcebbcdbce28d6b80056
Author: Duncan Grant <du...@cloudsoftcorp.com>
Date:   2017-11-15T09:55:41Z

    Fix VSP stop/start when ssh monitoring disabled
    
    When stop / starting a VanillaSoftwareProcess with ssh monitoring the
    process will never be marked as healthy after a stop start.
    
    On a restart the feeds are not disconnected so a service.notup.indicator
    is set.  When this is cleared on start the ServiceNotUpLogic will detect
    the change and set the isUp sensor true.  However when stopping the
    process feeds are disconnected so no service.notup indicators are set.
    This means the ServiceNotUp logic will not detect a change on start and
    won't set the service isUp sensor to true.
    
    Fixed by setting a service.notUp.indicator on stop.

----


---

[GitHub] brooklyn-server issue #900: Fix VSP stop/start when ssh monitoring disabled

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/brooklyn-server/pull/900
  
    SUCCESS 
     4934 tests run, 0 skipped, 0 failed.
    --none--


---

[GitHub] brooklyn-server issue #900: Fix VSP stop/start when ssh monitoring disabled

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/brooklyn-server/pull/900
  
    FAILURE
     3247 tests run, 1 skipped, 1 failed.
    --none--


---

[GitHub] brooklyn-server pull request #900: Fix VSP stop/start when ssh monitoring di...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/900


---

[GitHub] brooklyn-server issue #900: Fix VSP stop/start when ssh monitoring disabled

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/brooklyn-server/pull/900
  
    SUCCESS 
     4934 tests run, 0 skipped, 0 failed.
    --none--


---