You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/04 15:27:35 UTC
[GitHub] [doris] carlvinhust2012 opened a new pull request, #10598: [feature-wip] (array-type) add the array_sort function
carlvinhust2012 opened a new pull request, #10598:
URL: https://github.com/apache/doris/pull/10598
# Proposed changes
Issue Number: close #10052
this pr is used to add the array_sort function for array-type.
we can run this function in sql as follow:
MySQL [(none)]> set enable_array_type=true;
MySQL [(none)]> set enable_vectorized_engine=true;
MySQL [example_db]> select id, c_array, array_sort(c_array) from example_db.array_test;
+------+-----------------------------+-----------------------------+
| id | c_array | array_sort(`c_array`) |
+------+-----------------------------+-----------------------------+
| 1 | [1, 2, 3, 4, 5] | [1, 2, 3, 4, 5] |
| 2 | [6, 7, 8] | [6, 7, 8] |
| 3 | [] | [] |
| 4 | NULL | NULL |
| 5 | [1, 2, 3, 4, 5, 4, 3, 2, 1] | [1, 1, 2, 2, 3, 3, 4, 4, 5] |
| 6 | [1, 2, 3, NULL] | [NULL, 1, 2, 3] |
| 7 | [1, 2, 3, NULL, NULL] | [NULL, NULL, 1, 2, 3] |
| 8 | [1, 1, 2, NULL, NULL] | [NULL, NULL, 1, 1, 2] |
| 9 | [1, NULL, 1, 2, NULL, NULL] | [NULL, NULL, NULL, 1, 1, 2] |
+------+-----------------------------+-----------------------------+
9 rows in set (0.010 sec)
MySQL [example_db]> select id, c_array, array_sort(c_array) from example_db.array_test01;
+------+--------------------------+--------------------------+
| id | c_array | array_sort(`c_array`) |
+------+--------------------------+--------------------------+
| 1 | [a, b, c, d, e] | [a, b, c, d, e] |
| 2 | [f, g, h] | [f, g, h] |
| 3 | [] | [] |
| 3 | [NULL] | [NULL] |
| 5 | [a, b, c, d, e, a, b, c] | [a, a, b, b, c, c, d, e] |
| 6 | NULL | NULL |
| 7 | [a, b, NULL] | [NULL, a, b] |
| 8 | [a, b, NULL, NULL] | [NULL, NULL, a, b] |
+------+--------------------------+--------------------------+
8 rows in set (0.017 sec)
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r918688592
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ }
+ }
+
+ _sort_by_permutation<ColumnType>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+
+ dest_datas.push_back(src_datas[permutation[j]]);
+ if (dest_null_map) {
+ (*dest_null_map).push_back(false);
+ }
+ }
+ dest_offsets.push_back(curr_src_offset);
+ prev_src_offset = curr_src_offset;
+ }
+
+ return true;
+ }
+
+ bool _execute_string(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ const ColumnString* src_data_concrete = reinterpret_cast<const ColumnString*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+
+ ColumnString& dest_column_string = reinterpret_cast<ColumnString&>(dest_column);
+ ColumnString::Chars& column_string_chars = dest_column_string.get_chars();
+ ColumnString::Offsets& column_string_offsets = dest_column_string.get_offsets();
+ column_string_chars.reserve(src_column.size());
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ column_string_offsets.push_back(column_string_offsets.back());
+ (*dest_null_map).push_back(true);
+ }
+ }
+
+ _sort_by_permutation<ColumnString>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+
+ StringRef src_str_ref = src_data_concrete->get_data_at(permutation[j]);
+ // copy the src data to column_string_chars
+ const size_t old_size = column_string_chars.size();
+ const size_t new_size = old_size + src_str_ref.size + 1;
Review Comment:
no need to append zero char.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r917524082
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ }
+ }
+
+ _sort_by_permutation<ColumnType>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
Review Comment:
if the origin array is [1, null, 2, null, 3] and just use one loop, the dest_datas will push_back [1, null, 2, null, 3].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r918688592
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ }
+ }
+
+ _sort_by_permutation<ColumnType>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+
+ dest_datas.push_back(src_datas[permutation[j]]);
+ if (dest_null_map) {
+ (*dest_null_map).push_back(false);
+ }
+ }
+ dest_offsets.push_back(curr_src_offset);
+ prev_src_offset = curr_src_offset;
+ }
+
+ return true;
+ }
+
+ bool _execute_string(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ const ColumnString* src_data_concrete = reinterpret_cast<const ColumnString*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+
+ ColumnString& dest_column_string = reinterpret_cast<ColumnString&>(dest_column);
+ ColumnString::Chars& column_string_chars = dest_column_string.get_chars();
+ ColumnString::Offsets& column_string_offsets = dest_column_string.get_offsets();
+ column_string_chars.reserve(src_column.size());
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ column_string_offsets.push_back(column_string_offsets.back());
+ (*dest_null_map).push_back(true);
+ }
+ }
+
+ _sort_by_permutation<ColumnString>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+
+ StringRef src_str_ref = src_data_concrete->get_data_at(permutation[j]);
+ // copy the src data to column_string_chars
+ const size_t old_size = column_string_chars.size();
+ const size_t new_size = old_size + src_str_ref.size + 1;
Review Comment:
no need to append zero char.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r919126978
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
Review Comment:
I have re-check here. Even if it has been modified, the improvement is limited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r919615948
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ }
+ }
+
+ _sort_by_permutation<ColumnType>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
Review Comment:
got it, array_sort will put all nulls in front of array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10598:
URL: https://github.com/apache/doris/pull/10598#issuecomment-1186466881
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r917523106
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
Review Comment:
we should init permutation for each row?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r917521860
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ }
+ }
+
+ _sort_by_permutation<ColumnType>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
Review Comment:
it looks like, the two for-loop can merge to one.
// filter and insert null element first
// insert non-null element after sort by permutation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #10598:
URL: https://github.com/apache/doris/pull/10598#issuecomment-1185485006
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10598:
URL: https://github.com/apache/doris/pull/10598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r918682535
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
Review Comment:
put src_null_map outside of for loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
xy720 commented on PR #10598:
URL: https://github.com/apache/doris/pull/10598#issuecomment-1185437590
Please rebase master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10598:
URL: https://github.com/apache/doris/pull/10598#issuecomment-1186466897
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r917524082
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ }
+ }
+
+ _sort_by_permutation<ColumnType>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
Review Comment:
if the array is [1, null, 2, null, 3] and just use one loop, the dest_datas will push_back [1, null, 2, null, 3].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r917519972
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ }
+ }
+
+ _sort_by_permutation<ColumnType>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+
+ dest_datas.push_back(src_datas[permutation[j]]);
+ if (dest_null_map) {
+ (*dest_null_map).push_back(false);
+ }
+ }
+ dest_offsets.push_back(curr_src_offset);
+ prev_src_offset = curr_src_offset;
+ }
+
+ return true;
+ }
+
+ bool _execute_string(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ const ColumnString* src_data_concrete = reinterpret_cast<const ColumnString*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+
+ ColumnString& dest_column_string = reinterpret_cast<ColumnString&>(dest_column);
+ ColumnString::Chars& column_string_chars = dest_column_string.get_chars();
+ ColumnString::Offsets& column_string_offsets = dest_column_string.get_offsets();
+ column_string_chars.reserve(src_column.size());
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
+ permutation[i] = i;
+ }
+
+ for (auto curr_src_offset : src_offsets) {
+ // filter and insert null element first
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ DCHECK(dest_null_map != nullptr);
+ column_string_offsets.push_back(column_string_offsets.back());
+ (*dest_null_map).push_back(true);
+ }
+ }
+
+ _sort_by_permutation<ColumnString>(prev_src_offset, curr_src_offset, src_data_concrete,
+ src_column, src_null_map, permutation);
+
+ // insert non-null element after sort by permutation
+ for (ColumnArray::Offset j = prev_src_offset; j < curr_src_offset; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+
+ StringRef src_str_ref = src_data_concrete->get_data_at(permutation[j]);
+ // copy the src data to column_string_chars
+ const size_t old_size = column_string_chars.size();
+ const size_t new_size = old_size + src_str_ref.size + 1;
+ column_string_chars.resize(new_size);
+ if (src_str_ref.size > 0) {
+ memcpy(column_string_chars.data() + old_size, src_str_ref.data,
+ src_str_ref.size);
+ }
+ column_string_chars[old_size + src_str_ref.size] = 0;
+ column_string_offsets.push_back(new_size);
+
+ if (dest_null_map) {
+ (*dest_null_map).push_back(false);
+ }
+ }
+ dest_offsets.push_back(curr_src_offset);
+ prev_src_offset = curr_src_offset;
+ }
+ return true;
+ }
+
+ bool _execute_by_type(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map,
+ DataTypePtr& nested_type) {
+ bool res = false;
+ WhichDataType which(remove_nullable(nested_type)->get_type_id());
Review Comment:
```suggestion
WhichDataType which(remove_nullable(nested_type));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #10598:
URL: https://github.com/apache/doris/pull/10598#discussion_r917524726
##########
be/src/vec/functions/array/function_array_sort.h:
##########
@@ -0,0 +1,288 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arraySort.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+
+namespace doris::vectorized {
+
+class FunctionArraySort : public IFunction {
+public:
+ static constexpr auto name = "array_sort";
+ static FunctionPtr create() { return std::make_shared<FunctionArraySort>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ ColumnArray::Offsets& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(src_nested_column->size());
+ dest_offsets.reserve(input_rows_count);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ // sort the non-null element according to the permutation
+ template <typename SrcDataType>
+ void _sort_by_permutation(ColumnArray::Offset& prev_offset,
+ const ColumnArray::Offset& curr_offset,
+ const SrcDataType* src_data_concrete, const IColumn& src_column,
+ const NullMapType* src_null_map, IColumn::Permutation& permutation) {
+ for (ColumnArray::Offset j = prev_offset; j < curr_offset - 1; ++j) {
+ if (src_null_map && (*src_null_map)[j]) {
+ continue;
+ }
+ for (ColumnArray::Offset k = j + 1; k < curr_offset; ++k) {
+ if (src_null_map && (*src_null_map)[k]) {
+ continue;
+ }
+ int result = src_data_concrete->compare_at(permutation[j], permutation[k],
+ src_column, 1);
+ if (result > 0) {
+ auto temp = permutation[j];
+ permutation[j] = permutation[k];
+ permutation[k] = temp;
+ }
+ }
+ }
+ return;
+ }
+
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset prev_src_offset = 0;
+ IColumn::Permutation permutation(src_column.size());
+ for (size_t i = 0; i < src_column.size(); ++i) {
Review Comment:
the src_column.size() is the total number of the array elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #10598: [feature-wip] (array-type) add the array_sort function
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on PR #10598:
URL: https://github.com/apache/doris/pull/10598#issuecomment-1185469231
> Please rebase master.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org