[jira] [Commented] (HBASE-15679) Assertion on wrong variable in TestReplicationThrottler#testThrottling

["Stephen Yuan Jiang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248986#comment-15248986 ] 

Stephen Yuan Jiang commented on HBASE-15679:
--------------------------------------------

+1 Looks good to me.  Ted, thanks for catching this.

> Assertion on wrong variable in TestReplicationThrottler#testThrottling
> ----------------------------------------------------------------------
>
>                 Key: HBASE-15679
>                 URL: https://issues.apache.org/jira/browse/HBASE-15679
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 15679.v1.patch
>
>
> Sometimes TestReplicationThrottler#testThrottling failed with:
> {code}
> java.lang.AssertionError: null
> 	at org.junit.Assert.fail(Assert.java:86)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.junit.Assert.assertTrue(Assert.java:52)
> 	at org.apache.hadoop.hbase.replication.regionserver.TestReplicationThrottler.testThrottling(TestReplicationThrottler.java:75)
> {code}
> Looking closer, we can see that the wrong variable is used for the assertion:
> {code}
>     if (ticks2 != 10000 && ticks2 != 9999) {
>       assertTrue(ticks1 >= 7500 && ticks1 <=10000);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)