[GitHub] [spark] cloud-fan commented on a diff in pull request #39076: [SPARK-41530][CORE] Extend MedianHeap to support percentile

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #39076:
URL: https://github.com/apache/spark/pull/39076#discussion_r1050317526


##########
core/src/test/scala/org/apache/spark/util/collection/PercentileHeapSuite.scala:
##########
@@ -21,46 +21,67 @@ import java.util.NoSuchElementException
 
 import org.apache.spark.SparkFunSuite
 
-class MedianHeapSuite extends SparkFunSuite {
+class PercentileHeapSuite extends SparkFunSuite {
 
-  test("If no numbers in MedianHeap, NoSuchElementException is thrown.") {
-    val medianHeap = new MedianHeap()
+  test("If no numbers in PercentileHeap, NoSuchElementException is thrown.") {
+    val medianHeap = new PercentileHeap()

Review Comment:
   This is OK, the default percentile is 0.5 which is essentially a median.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org