You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/01/28 00:58:31 UTC

Review Request 17432: Fix regression causing secondary index to store duplicate tasks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17432/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-126
    https://issues.apache.org/jira/browse/AURORA-126


Repository: aurora


Description
-------

Fix regression causing secondary index to store duplicate tasks.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java eaf18dccacaaceb422edcbac0dd2459acd1e19d5 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java ff5bf8993bd143c068df3139479839de8a914c70 

Diff: https://reviews.apache.org/r/17432/diff/


Testing
-------

Added test case to reproduce regression, ./gradlew build passes.


Thanks,

Bill Farner


Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17432/#review32916
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 27, 2014, 3:58 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17432/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 3:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-126
>     https://issues.apache.org/jira/browse/AURORA-126
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix regression causing secondary index to store duplicate tasks.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java eaf18dccacaaceb422edcbac0dd2459acd1e19d5 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java ff5bf8993bd143c068df3139479839de8a914c70 
> 
> Diff: https://reviews.apache.org/r/17432/diff/
> 
> 
> Testing
> -------
> 
> Added test case to reproduce regression, ./gradlew build passes.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17432/#review32917
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Jan. 27, 2014, 11:58 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17432/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 11:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-126
>     https://issues.apache.org/jira/browse/AURORA-126
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix regression causing secondary index to store duplicate tasks.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java eaf18dccacaaceb422edcbac0dd2459acd1e19d5 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java ff5bf8993bd143c068df3139479839de8a914c70 
> 
> Diff: https://reviews.apache.org/r/17432/diff/
> 
> 
> Testing
> -------
> 
> Added test case to reproduce regression, ./gradlew build passes.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>