You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iggy.apache.org by "kriti-sc (via GitHub)" <gi...@apache.org> on 2026/07/04 16:44:33 UTC
Re: Manual Offset Commit
GitHub user kriti-sc added a comment to the discussion: Manual Offset Commit
thought about this a bit more:
i am not sure if the offset advancing decision should hinge on i32 ( returned by sink @[sink.rs:740](https://github.com/apache/iggy/blob/7b2db334f244df06805f2c76c0490a5c1a6ec7e5/core/connectors/runtime/src/sink.rs#L740) )
Because a sink returning non-zero on a batch means a non-transient error, and the only option at this point is routing the batch to DLQ. Otherwise, the process will remain stuck on the same offset. So the offset should advance once sink returns regardless of success of the batch.
Re the i32 -- until the DLQ, I am not seeing any utility so [sink.rs:740](https://github.com/apache/iggy/blob/7b2db334f244df06805f2c76c0490a5c1a6ec7e5/core/connectors/runtime/src/sink.rs#L740) can remain as it is.
let me know thoughts @hubcio
GitHub link: https://github.com/apache/iggy/discussions/3203#discussioncomment-17532884
----
This is an automatically sent email for dev@iggy.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@iggy.apache.org