[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #997: Fix build error when project path contains `kyuubi-`

[GitBox <gi...@apache.org>]

pan3793 commented on a change in pull request #997:
URL: https://github.com/apache/incubator-kyuubi/pull/997#discussion_r698140940



##########
File path: build/release/collect-licenses.sh
##########
@@ -43,12 +43,14 @@ if [ "${SRC}" = "-h" ]; then
 	exit 0
 fi
 
-for jar_file in $(find -L "${SRC}" -name "*.jar" | grep -v "kyuubi-")
+for jar_file in $(find -L "${SRC}" -name "*.jar")
 do
-	DIR="${TMP}/$(basename -- "${jar_file}" .jar)"
-	mkdir -p "${DIR}"
-	JAR=$(realpath "${jar_file}")
-	(cd "${DIR}" && jar xf ${JAR} META-INF/NOTICE META-INF/licenses)
+  if [[ $(basename $jar_file) != kyuubi-* ]]; then

Review comment:
       Would you please also replace all `tab` in this script with `2 spaces`?
   BTW, please keep the same code style with original content, e.g. `${jar_file}`, and quote string by `"`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org