You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/16 20:50:03 UTC

[kudu-CR](branch-1.11.x) [clock] more info on refusal to advance hybrid timestamp 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14465


Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................

[clock] more info on refusal to advance hybrid timestamp

Enhanced the error message on the attempt to update hybrid timestamp
beyond the maximum allowed error threshold.

This patch does not contain any functional changes.

Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Reviewed-on: http://gerrit.cloudera.org:8080/14455
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 3bd293d0f32003e877e7f160365ffd238927e164)
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 11 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/14465/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14465
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR](branch-1.11.x) [clock] more info on refusal to advance hybrid timestamp

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14465 )

Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14465
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Oct 2019 20:52:07 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.11.x) [clock] more info on refusal to advance hybrid timestamp

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14465 )

Change subject: [clock] more info on refusal to advance hybrid timestamp
......................................................................

[clock] more info on refusal to advance hybrid timestamp

Enhanced the error message on the attempt to update hybrid timestamp
beyond the maximum allowed error threshold.

This patch does not contain any functional changes.

Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Reviewed-on: http://gerrit.cloudera.org:8080/14455
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 3bd293d0f32003e877e7f160365ffd238927e164)
Reviewed-on: http://gerrit.cloudera.org:8080/14465
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 11 insertions(+), 7 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I676fc89fb96fa5383ae354207b64bed3ffe00300
Gerrit-Change-Number: 14465
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)