You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/08 23:54:23 UTC
[GitHub] [airflow] kaxil opened a new pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code
kaxil opened a new pull request #16342:
URL: https://github.com/apache/airflow/pull/16342
- [ ] Add note in Updating.md
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #16342:
URL: https://github.com/apache/airflow/pull/16342#issuecomment-858122998
> Can you explain a little more why you want to delete this option?
Hey yeah, was going to do it once the PR was ready for review. The thought behind it is, since this option is `True` by default in anyway and since the Webserver is relying on serialized DAGs and not file, let's remove the last thing that might use DAG files (if `store_dag_code=False`). I thought of this as many people were confusing this setting for DAG Serialization. They didn't realize that this setting is ONLY used for showing DAG Source Code in Code View (that's it), example: https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1621946017296000?thread_ts=1620925239.197200&cid=CCQ7EGB1P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16342:
URL: https://github.com/apache/airflow/pull/16342#issuecomment-899895896
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #16342:
URL: https://github.com/apache/airflow/pull/16342#issuecomment-857346455
Can you explain a little more why you want to delete this option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #16342:
URL: https://github.com/apache/airflow/pull/16342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #16342:
URL: https://github.com/apache/airflow/pull/16342#discussion_r692424237
##########
File path: UPDATING.md
##########
@@ -174,6 +174,20 @@ with DAG(dag_id="task_concurrency_example"):
When marking a task success/failed in Graph View, its downstream tasks that are in failed/upstream_failed state are automatically cleared.
+### `[core] store_dag_code` has been removed
+
+While DAG Serialization is a strict requirements since Airflow 2, we allowed users to control
+where the Webserver looked for when showing the **Code View**.
+
+If `[core] store_dag_code` was set to `True`, the Scheduler stored the code in the DAG file in the
+DB (in `dag_code` table) as plain string. And the webserver just read it from the same table.
Review comment:
```suggestion
DB (in `dag_code` table) as a plain string, and the webserver just read it from the same table.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16342: Remove ``[core] store_dag_code`` & use DB to get Dag Code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16342:
URL: https://github.com/apache/airflow/pull/16342#issuecomment-902186401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org