You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/23 02:23:54 UTC
[GitHub] [spark] Yikun opened a new pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Yikun opened a new pull request #35284:
URL: https://github.com/apache/spark/pull/35284
### What changes were proposed in this pull request?
Add a friendly error message for `black` version mismatched.
### Why are the changes needed?
Before this patch:
```bash
$ dev/reformat-python
Oh no! 💥 💔 💥 The required version `21.12b0` does not match the running version `21.7b0`!
```
After this patch:
```bash
$ dev/reformat-python
The required version '21.12b0' does not match the running version '21.7b0', Please re-install Black, for example, via 'pip install black==21.12b0'.
```
### Does this PR introduce _any_ user-facing change?
NO, dev only
### How was this patch tested?
Manually test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35284:
URL: https://github.com/apache/spark/pull/35284#issuecomment-1019592467
OK, if there are any other conplains we can reopen this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35284:
URL: https://github.com/apache/spark/pull/35284#issuecomment-1019493406
> I am not against this, if others find it useful, but personally, I don't see the improvement (if anything, we could add an info line, i.e. _reformatting with black..._, that would provide a context for the operation).
>
> That being said, tested locally, and works as advertised.
Agree, the background is I just confused by the previous warning yesterday, because I didn't know which package version is mismatch. 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35284:
URL: https://github.com/apache/spark/pull/35284#issuecomment-1019592467
OK, if there are any other one conplains we can reopen this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35284:
URL: https://github.com/apache/spark/pull/35284#issuecomment-1019493406
> we could add an info line, i.e. _reformatting with black..._, that would provide a context for the operation
yep, this is also okay.
The background is I just confused by the previous warning yesterday, because I didn't know which package version is mismatch. 😂
And the messge includes information:
1. to point which package
2. also give a friendly solution, then the devs can copy/paste the cmd to reinstall it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35284:
URL: https://github.com/apache/spark/pull/35284#issuecomment-1019592467
OK, if there are any other one conplains we can reopen this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun closed pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Posted by GitBox <gi...@apache.org>.
Yikun closed pull request #35284:
URL: https://github.com/apache/spark/pull/35284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #35284:
URL: https://github.com/apache/spark/pull/35284#issuecomment-1019560188
> The background is I just confused by the previous warning yesterday, because I didn't know which package version is mismatch. 😂
I guessed that much, trying to figure out why the current message might be confusing :)
I am just not that fond of having package versions all over the place and keeping these in sync, unless it is strictly necessary (here, we have dev script with limited target audience, clear scope and version checks we get for free). This doesn't add new place, but adding more consumers, makes us less likely to remove it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35284: [SPARK-37988][PYTHON] Fix confused warning for `black` version mismatched
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35284:
URL: https://github.com/apache/spark/pull/35284#issuecomment-1019398383
cc @zero323 @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org