You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/10 05:14:35 UTC

[GitHub] [spark] dcoliversun commented on a change in pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements

dcoliversun commented on a change in pull request #35758:
URL: https://github.com/apache/spark/pull/35758#discussion_r823354449



##########
File path: common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java
##########
@@ -134,8 +134,12 @@ public StoreVersion(@JsonProperty("major") int major, @JsonProperty("minor") int
 
     @Override
     public boolean equals(Object o) {
-      if (this == o) return true;

Review comment:
       I don't know about these. Sorry to bother you too. Please ignore this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org