[GitHub] [pinot] klsince commented on a diff in pull request #11226: [bugfix] Do not move real-time segments to working dir on restart

["klsince (via GitHub)" <gi...@apache.org>]

klsince commented on code in PR #11226:
URL: https://github.com/apache/pinot/pull/11226#discussion_r1279693383


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -390,6 +390,9 @@ public void addSegment(String segmentName, IndexLoadingConfig indexLoadingConfig
       return;
     }
 
+    // Assign table directory to not let the segment be moved during loading/preprocessing
+    indexLoadingConfig.setTableDataDir(_tableDataDir);

Review Comment:
   good catch!
   
   As in BaseTableDataMgr, we would also need tier and tierConfigs like below, for segments (particularly those immutable ones) to stay on the expected tiers they were moved to previously. Otherwise, they'd be put back on the default tier when server restarts, and then get moved back to the expected tiers by SegmentRelocator.
   ```
   indexLoadingConfig.setTableDataDir(_tableDataDir);
   indexLoadingConfig.setSegmentTier(segmentTier);
   indexLoadingConfig.setInstanceTierConfigs(_tableDataManagerConfig.getInstanceTierConfigs());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org