You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by xi...@apache.org on 2025/02/21 22:50:56 UTC

(tinkerpop) 02/04: revert map to not support ordered map derser, updated set, added marker class

This is an automated email from the ASF dual-hosted git repository.

xiazcy pushed a commit to branch go-opts-strat-gl-updates
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit fe007159050e3bc61ae910169c8db74d2710a0ac
Author: Yang Xia <55...@users.noreply.github.com>
AuthorDate: Thu Feb 20 12:49:43 2025 -0800

    revert map to not support ordered map derser, updated set, added marker class
---
 gremlin-go/driver/graphBinary_test.go | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/gremlin-go/driver/graphBinary_test.go b/gremlin-go/driver/graphBinary_test.go
index 53911e193e..cc80c27ccf 100644
--- a/gremlin-go/driver/graphBinary_test.go
+++ b/gremlin-go/driver/graphBinary_test.go
@@ -24,7 +24,6 @@ import (
 	"encoding/binary"
 	"fmt"
 	"github.com/stretchr/testify/assert"
-	"github.com/wk8/go-ordered-map/v2"
 	"golang.org/x/text/language"
 	"math/big"
 	"reflect"
@@ -219,23 +218,10 @@ func TestGraphBinaryV1(t *testing.T) {
 			source := map[interface{}]interface{}{1: "s1", "s2": 2, nil: nil}
 			buf, err := mapWriter(source, &buffer, nil)
 			assert.Nil(t, err)
-			res, err := readMap(&buf, &pos, 0x00)
+			res, err := readMap(&buf, &pos)
 			assert.Nil(t, err)
 			assert.Equal(t, fmt.Sprintf("%v", source), fmt.Sprintf("%v", res))
 		})
-		t.Run("read-write ordered map", func(t *testing.T) {
-			pos := 0
-			var buffer bytes.Buffer
-			source := orderedmap.New[interface{}, interface{}]()
-			source.Set(int32(1), "s1")
-			source.Set(int32(2), "s2")
-			source.Set(nil, nil)
-			buf, err := mapWriter(source, &buffer, nil)
-			assert.Nil(t, err)
-			res, err := readMap(&buf, &pos, 0x02)
-			assert.Nil(t, err)
-			assert.Equal(t, source, res)
-		})
 		t.Run("read incomparable map: a map value as the key", func(t *testing.T) {
 			// prepare test data
 			var buf = &bytes.Buffer{}
@@ -259,7 +245,7 @@ func TestGraphBinaryV1(t *testing.T) {
 
 			data := buf.Bytes()
 			i := 0
-			result, err := readMap(&data, &i, 0x00)
+			result, err := readMap(&data, &i)
 			if err != nil {
 				t.Fatalf("readMap failed: %v", err)
 			}
@@ -295,7 +281,7 @@ func TestGraphBinaryV1(t *testing.T) {
 
 			data := buf.Bytes()
 			i := 0
-			result, err := readMap(&data, &i, 0x00)
+			result, err := readMap(&data, &i)
 			if err != nil {
 				t.Fatalf("readMap failed: %v", err)
 			}