You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/05/14 06:55:11 UTC
[GitHub] [yunikorn-k8shim] steinsgateted opened a new pull request, #424: [YUNIKORN-1210] Change the error log of handleRecoverApplicationEvent function
steinsgateted opened a new pull request, #424:
URL: https://github.com/apache/yunikorn-k8shim/pull/424
### What is this PR for?
The error log in `handleRecoverApplicationEvent(event *fsm.Event)` should be changed to failed to recover app.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1210
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #424: [YUNIKORN-1210] Change the error log of handleRecoverApplicationEvent function
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #424:
URL: https://github.com/apache/yunikorn-k8shim/pull/424#issuecomment-1126659382
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#424](https://codecov.io/gh/apache/yunikorn-k8shim/pull/424?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (265de0c) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/dc1faba1b5f18210b8f4216cfc57cb001e787b51?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc1faba) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 65.50% 65.50%
=======================================
Files 40 40
Lines 6406 6406
=======================================
Hits 4196 4196
Misses 2047 2047
Partials 163 163
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/application.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `73.04% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/424?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/424?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc1faba...265de0c](https://codecov.io/gh/apache/yunikorn-k8shim/pull/424?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #424: [YUNIKORN-1210] Change the error log of handleRecoverApplicationEvent function
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #424: [YUNIKORN-1210] Change the error log of handleRecoverApplicationEvent function
URL: https://github.com/apache/yunikorn-k8shim/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org