You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/05/24 07:45:39 UTC
[kudu-CR](branch-1.17.x) KUDU-1945 Update docs with non-unique PK
Hello Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19924
to review the following change.
Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................
KUDU-1945 Update docs with non-unique PK
Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.
Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Reviewed-on: http://gerrit.cloudera.org:8080/19809
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M docs/administration.adoc
M docs/schema_design.adoc
2 files changed, 40 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/19924/1
--
To view, visit http://gerrit.cloudera.org:8080/19924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19924
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR](branch-1.17.x) KUDU-1945 Update docs with non-unique PK
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19924 )
Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19924
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 May 2023 17:27:14 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-1945 Update docs with non-unique PK
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19924 )
Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................
KUDU-1945 Update docs with non-unique PK
Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.
Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Reviewed-on: http://gerrit.cloudera.org:8080/19809
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/19924
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M docs/administration.adoc
M docs/schema_design.adoc
2 files changed, 40 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Marton Greber: Looks good to me, but someone else must approve
Wenzhe Zhou: Looks good to me, but someone else must approve
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19924
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) KUDU-1945 Update docs with non-unique PK
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19924 )
Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19924
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 25 May 2023 02:15:32 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-1945 Update docs with non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19924 )
Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19924
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 May 2023 09:31:09 +0000
Gerrit-HasComments: No