[GitHub] spark pull request #17035: [SPARK-19705][SQL] Preferred location supporting ...

[rezasafi <gi...@git.apache.org>]

Github user rezasafi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17035#discussion_r128637990
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala ---
    @@ -205,7 +208,13 @@ class FileScanRDD(
     
       override protected def getPreferredLocations(split: RDDPartition): Seq[String] = {
         val files = split.asInstanceOf[FilePartition].files
    -
    +    if (files.size == 1) {
    +      val cachedLocations = files.head.cachedLocations.map(HDFSCacheTaskLocation(_).toString)
    +      val nonCachedLocations = files.head.locations.filterNot { x =>
    +          files.head.cachedLocations.contains(x)
    +        }.map(HostTaskLocation(_).toString)
    +      return cachedLocations ++ nonCachedLocations
    --- End diff --
    
    Is it possible to rewrite this to avoid using return? thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org