You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/08 17:33:36 UTC

[GitHub] csantanapr commented on a change in pull request #28: Add PHP 7.2.6 runtime

csantanapr commented on a change in pull request #28: Add PHP 7.2.6 runtime
URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/28#discussion_r194129035
 
 

 ##########
 File path: core/php7.2Action/php.ini
 ##########
 @@ -0,0 +1,1948 @@
+; Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   this file looks too big and boiler plate.
   Can we have a short version with a few settings that we need to override

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services