You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Sergey Beryozkin <sb...@gmail.com> on 2016/03/02 11:21:35 UTC

Re: cxf git commit: [CXF-6814]:ClientRequestFilter should be added with descending order of priority

Hi Jim

Thanks for your effort so far.

I'd like to suggest that before sensitive changes are made the dev 
thread gets initiated first.

Can you explain why you made this change ?

Thanks, Sergey

On 02/03/16 09:03, ema@apache.org wrote:
> Repository: cxf
> Updated Branches:
>    refs/heads/master 6f4bc7afa -> 15ab1324e
>
>
> [CXF-6814]:ClientRequestFilter should be added with descending order of priority
>
>
> Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
> Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/15ab1324
> Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/15ab1324
> Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/15ab1324
>
> Branch: refs/heads/master
> Commit: 15ab1324e0ebdaa45422048837298c503cf44d0f
> Parents: 6f4bc7a
> Author: Jim Ma <em...@apache.org>
> Authored: Wed Mar 2 17:01:43 2016 +0800
> Committer: Jim Ma <em...@apache.org>
> Committed: Wed Mar 2 17:01:43 2016 +0800
>
> ----------------------------------------------------------------------
>   .../java/org/apache/cxf/jaxrs/client/ClientProviderFactory.java    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/cxf/blob/15ab1324/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProviderFactory.java
> ----------------------------------------------------------------------
> diff --git a/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProviderFactory.java b/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProviderFactory.java
> index dd2522e..6e28a1f 100644
> --- a/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProviderFactory.java
> +++ b/rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProviderFactory.java
> @@ -87,7 +87,7 @@ public final class ClientProviderFactory extends ProviderFactory {
>               }
>           }
>           Collections.sort(clientRequestFilters,
> -                         new BindingPriorityComparator(ClientRequestFilter.class, true));
> +                         new BindingPriorityComparator(ClientRequestFilter.class, false));
>           Collections.sort(clientResponseFilters,
>                            new BindingPriorityComparator(ClientResponseFilter.class, false));
>
>


-- 
Sergey Beryozkin

Talend Community Coders
http://coders.talend.com/