You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/03/31 03:29:00 UTC

[jira] [Commented] (IMPALA-10606) Simplify impala-python virtualenv requirements files

    [ https://issues.apache.org/jira/browse/IMPALA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312008#comment-17312008 ] 

ASF subversion and git services commented on IMPALA-10606:
----------------------------------------------------------

Commit 9670c1455d7088bf76cb285f2f00f212e3df647c in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9670c14 ]

IMPALA-10606 (part 2): Clean up ordering of requirements.txt

This is a followup to the original IMPALA-10606 that reorders
the requirements.txt alphabetically. No versions changed
as part of this.

Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Reviewed-on: http://gerrit.cloudera.org:8080/17229
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>


> Simplify impala-python virtualenv requirements files
> ----------------------------------------------------
>
>                 Key: IMPALA-10606
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10606
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 4.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Major
>
> The impala-python virtualenv currently has complicated logic that can do multiple rounds of pip installs depending on whether the toolchain has been bootstrapped. For example, the packages in compile-requirements.txt are only installed if the toolchain GCC has been installed. The Kudu python client is only installed if Kudu has been downloaded. This was a workaround because bootstrap_toolchain.py required the impala-python virtualenv. The different stages allowed the basics to be installed, then bootstrap_toolchain.py can run, then the rest can be installed.
> The bootstrap_toolchain.py script no longer requires the impala-python virtualenv, so there is no need for such a complicated setup. The things bootstrapping the impala-python virtualenv can assume that the toolchain compiler is present. This would allow the requirements to be consolidated into a main requirements file that includes both compiled and non-compiled packages. A consolidated file makes it easier to update dependency versions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org