[GitHub] GabrielBrascher commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain

[gi...@git.apache.org]

GabrielBrascher commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain
URL: https://github.com/apache/cloudstack/pull/2124#issuecomment-310246543
 
 
   Hi @remibergsma . Thanks for the feedback!
   
   (i) the account ID in the affinity_group table: I kept the account ID as the owner account id (in this case 1 because of the system account id) because I don't know the effect of letting it null; thus, the account ID stayed as it was being managed before this fix. Please feel free to provide any different approach if you have something in mind.
   
   (i) the domain ID in affinity_group table: if I didn't miss anything, the domain ID should be from the dedicated domain ID (instead of 1). Line 186 `AffinityGroupVO group = new AffinityGroupVO(affinityGroupName, affinityGroupType, description, affinityGroupDomainId, owner.getId(), aclType);` creates an AffinityGroupVO with the domain id `affinityGroupDomainId`. I will test this again to be sure.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services