[GitHub] [iceberg] jackye1995 commented on a change in pull request #2050: AWS: consolidate config key names before release

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #2050:
URL: https://github.com/apache/iceberg/pull/2050#discussion_r554106569



##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -112,13 +112,13 @@
    * switch from uploading using a single put object request to uploading using multipart upload
    * (default: 1.5).
    */
-  public static final String S3FILEIO_MULTIPART_THRESHOLD_FACTOR = "s3fileio.multipart.threshold";
+  public static final String S3FILEIO_MULTIPART_THRESHOLD_FACTOR = "s3.multipart.threshold";

Review comment:
       My understanding is that `s3.multipart.*` has all the multipart upload configs, that's why I kept it unchanged.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org