You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Toshiaki Masaki (JIRA)" <ji...@apache.org> on 2008/06/19 10:35:46 UTC
[jira] Created: (NET-223) the data connection socket is not closed
when an IOException occurred
the data connection socket is not closed when an IOException occurred
---------------------------------------------------------------------
Key: NET-223
URL: https://issues.apache.org/jira/browse/NET-223
Project: Commons Net
Issue Type: Bug
Affects Versions: 1.4
Environment: Windows
Reporter: Toshiaki Masaki
In method FTPClient.initiateListParsing(FTPFileEntryParser, String),
the data connection socket is not closed when an IOException(e.g. SocketTimeoutException)
occurred while calling FTPListParseEngine.readServerList().
> engine.readServerList(socket.getInputStream(), getControlEncoding());
> socket.close();
In other methods that open a data connection socket, like retrieveFile() and __storeFile(),
the socket is closed when an IOException occurred.
I think, the client should close the socket like the following.
> try {
> engine.readServerList(socket.getInputStream(), getControlEncoding());
> } finally {
> socket.close();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (NET-223) the data connection socket is not closed
when an IOException occurred
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-223.
----------------------
Resolution: Fixed
Fix Version/s: 2.0
1.5
Thanks for the report; fix applied to trunk and branch 2.0:
URL: http://svn.apache.org/viewvc?rev=669460&view=rev
Log:
NET-223 - the data connection socket is not closed when an IOException occurred
> the data connection socket is not closed when an IOException occurred
> ---------------------------------------------------------------------
>
> Key: NET-223
> URL: https://issues.apache.org/jira/browse/NET-223
> Project: Commons Net
> Issue Type: Bug
> Affects Versions: 1.4
> Environment: Windows
> Reporter: Toshiaki Masaki
> Fix For: 1.5, 2.0
>
>
> In method FTPClient.initiateListParsing(FTPFileEntryParser, String),
> the data connection socket is not closed when an IOException(e.g. SocketTimeoutException)
> occurred while calling FTPListParseEngine.readServerList().
> > engine.readServerList(socket.getInputStream(), getControlEncoding());
> > socket.close();
> In other methods that open a data connection socket, like retrieveFile() and __storeFile(),
> the socket is closed when an IOException occurred.
> I think, the client should close the socket like the following.
> > try {
> > engine.readServerList(socket.getInputStream(), getControlEncoding());
> > } finally {
> > socket.close();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.