You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/08 08:40:33 UTC

[GitHub] [superset] villebro commented on a diff in pull request #19587: chore: cleanup as unknown conversion

villebro commented on code in PR #19587:
URL: https://github.com/apache/superset/pull/19587#discussion_r845879275


##########
superset-frontend/packages/superset-ui-core/test/query/buildQueryObject.test.ts:
##########
@@ -285,7 +285,8 @@ describe('buildQueryObject', () => {
         datasource: '5__table',
         granularity_sqla: 'ds',
         viz_type: 'table',
-        url_params: null as unknown as undefined,
+        // @ts-ignore

Review Comment:
   I believe `// @ts-expect-error` is the correct syntax for testing with incorrect types



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org