You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/03/20 05:08:37 UTC

Review Request 19448: [HELIX-410] Fix parsing of resources in ClusterStateVerifier

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19448/
-----------------------------------------------------------

Review request for helix, Zhen Zhang and Kishore Gopalakrishna.


Bugs: HELIX-410


Repository: helix-git


Description
-------

commit ca4fc8c3bdbb6684165a0715d5aabdcbccc2bfdf
Author: Kanak Biscuitwala <ka...@hotmail.com>
Date:   Wed Mar 19 21:05:57 2014 -0700

    [HELIX-410] Fix parsing of resources in ClusterStateVerifier

:100644 100644 cc171a0... 458218c... M	helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
:100644 100644 3a3a09e... bd749c3... M	helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java
:100644 100644 ae154d3... dc6bd45... M	helix-core/src/test/java/org/apache/helix/tools/TestClusterStateVerifier.java


Diffs
-----

  helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java cc171a0 
  helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java 3a3a09e 
  helix-core/src/test/java/org/apache/helix/tools/TestClusterStateVerifier.java ae154d3 

Diff: https://reviews.apache.org/r/19448/diff/


Testing
-------

Added a test case to verify the usage.


Thanks,

Kanak Biscuitwala


Re: Review Request 19448: [HELIX-410] Fix parsing of resources in ClusterStateVerifier

Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19448/#review37995
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On March 20, 2014, 4:08 a.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19448/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 4:08 a.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-410
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit ca4fc8c3bdbb6684165a0715d5aabdcbccc2bfdf
> Author: Kanak Biscuitwala <ka...@hotmail.com>
> Date:   Wed Mar 19 21:05:57 2014 -0700
> 
>     [HELIX-410] Fix parsing of resources in ClusterStateVerifier
> 
> :100644 100644 cc171a0... 458218c... M	helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
> :100644 100644 3a3a09e... bd749c3... M	helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java
> :100644 100644 ae154d3... dc6bd45... M	helix-core/src/test/java/org/apache/helix/tools/TestClusterStateVerifier.java
> 
> 
> Diffs
> -----
> 
>   helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java cc171a0 
>   helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java 3a3a09e 
>   helix-core/src/test/java/org/apache/helix/tools/TestClusterStateVerifier.java ae154d3 
> 
> Diff: https://reviews.apache.org/r/19448/diff/
> 
> 
> Testing
> -------
> 
> Added a test case to verify the usage.
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>