[jira] [Commented] (FLINK-1292) Allow for longer normalized keys

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229876#comment-14229876 ] 

ASF GitHub Bot commented on FLINK-1292:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/incubator-flink/pull/241#issuecomment-65075554
  
    LGTM


> Allow for longer normalized keys
> --------------------------------
>
>                 Key: FLINK-1292
>                 URL: https://issues.apache.org/jira/browse/FLINK-1292
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 0.8-incubating
>            Reporter: Stephan Ewen
>             Fix For: 0.8-incubating
>
>
> The normalized key sorter currently has a hardwired limit of a normalized key size of 8 bytes. This still comes from the "single key" era.
> For composite keys, this length is easily exceeded and sorts cannot happen as fast as the could. On the other hand, setting the value arbitrarily large impacts memory consumption.
> I propose to extend this to allow for 8 bytes per key up to a total length of 16 bytes. This fits at least two composite longs, or a sequence of Ints.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)