You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by narendly <gi...@git.apache.org> on 2018/07/24 19:20:56 UTC

[GitHub] helix pull request #260: [TASK] Fix purgeExpiredJobs() so that jobs whose re...

GitHub user narendly opened a pull request:

    https://github.com/apache/helix/pull/260

    [TASK] Fix purgeExpiredJobs() so that jobs whose removal has failed do not get removed from DAG

    …led do not get removed from DAG
    
    Previously, even if the job removal had failed, Task Framework would go ahead and remove the job from the DAG. This would cause some ZNodes to be left over and never be cleaned up at next purge time.
    Changelist:
    1. Keep track of jobs whose removal failed and remove them from expiredJobs so that next call to purgeExpiredJobs(), the job would be included in expiredJobs again and removal would be tried again.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/narendly/helix 1364883

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #260
    
----
commit c012c7b9dea35137935ac29c035a96aea570bf9c
Author: Hunter Lee <na...@...>
Date:   2018-07-24T19:20:00Z

    [HELIX-743] Fix purgeExpiredJobs() so that jobs whose removal has failed do not get removed from DAG
    
    Previously, even if the job removal had failed, Task Framework would go ahead and remove the job from the DAG. This would cause some ZNodes to be left over and never be cleaned up at next purge time.
    Changelist:
    1. Keep track of jobs whose removal failed and remove them from expiredJobs so that next call to purgeExpiredJobs(), the job would be included in expiredJobs again and removal would be tried again.

----


---

[GitHub] helix pull request #260: [TASK] Fix purgeExpiredJobs() so that jobs whose re...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/260


---