You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by dr...@apache.org on 2008/07/24 21:20:33 UTC

svn commit: r679505 - /incubator/thrift/trunk/lib/java/src/com/facebook/thrift/transport/TServerSocket.java

Author: dreiss
Date: Thu Jul 24 12:20:32 2008
New Revision: 679505

URL: http://svn.apache.org/viewvc?rev=679505&view=rev
Log:
THRIFT-64. java: Allow TServerSocket to bind to a specific IP address

Add a new constructor to TServerSocket that accepts an InetSocketAddress
and binds to that address.  Define the old constructor (which just takes
a port) in terms of the new one.

Modified:
    incubator/thrift/trunk/lib/java/src/com/facebook/thrift/transport/TServerSocket.java

Modified: incubator/thrift/trunk/lib/java/src/com/facebook/thrift/transport/TServerSocket.java
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/lib/java/src/com/facebook/thrift/transport/TServerSocket.java?rev=679505&r1=679504&r2=679505&view=diff
==============================================================================
--- incubator/thrift/trunk/lib/java/src/com/facebook/thrift/transport/TServerSocket.java (original)
+++ incubator/thrift/trunk/lib/java/src/com/facebook/thrift/transport/TServerSocket.java Thu Jul 24 12:20:32 2008
@@ -64,7 +64,15 @@
    * Creates just a port listening server socket
    */
   public TServerSocket(int port, int clientTimeout) throws TTransportException {
+    this(new InetSocketAddress(port), clientTimeout);
     port_ = port;
+  }
+
+  public TServerSocket(InetSocketAddress bindAddr) throws TTransportException {
+    this(bindAddr, 0);
+  }
+
+  public TServerSocket(InetSocketAddress bindAddr, int clientTimeout) throws TTransportException {
     clientTimeout_ = clientTimeout;
     try {
       // Make server socket
@@ -72,10 +80,10 @@
       // Prevent 2MSL delay problem on server restarts
       serverSocket_.setReuseAddress(true);
       // Bind to listening port
-      serverSocket_.bind(new InetSocketAddress(port_));
+      serverSocket_.bind(bindAddr);
     } catch (IOException ioe) {
       serverSocket_ = null;
-      throw new TTransportException("Could not create ServerSocket on port " + port + ".");
+      throw new TTransportException("Could not create ServerSocket on address " + bindAddr.toString() + ".");
     }
   }